GH Issue 1412: Don't allow job task ids for assay types not referenced in actions - #8010
Merged
Conversation
cnathe
approved these changes
Sep 2, 2026
| WorkflowService workService = WorkflowService.get(); | ||
|
|
||
| if (workService != null && protocol != null && !workService.isTaskAssayType(workflowTaskId, protocol.getRowId())) | ||
| throw new ExperimentException("Invalid job task id " + workflowTaskId + ". Either the task does not exist or does not reference this assay type."); |
Contributor
There was a problem hiding this comment.
so we weren't even validating that the workflowTaskId was an existing task before? Nice to get both of those validations here in one place.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Issue 1412
Related Pull Requests
Changes