Merge Sample Type UI creation and editing into one page - #894
Merged
Conversation
- Configure list module for React page. - Add Experimental feature to toggle on/off the new React page.
…date nav trail and move props code.
… fields in addition to List property).
…hing at the platform repository level.
…ist_designer_6798
…ist_designer_6798
…hich also returns domain kind specific properties; and related refactoring.
…stPropertiesAction to be able to get domainId.
…s Binal's GetListPropertiesAction and GetDomainDetails
…ist_designer_6798
… CreateDomain: - Generified DomainKind. - Added new method getTypeClass() in DomainKind. - Update ListDomainKind to implement new method with appropriate bean (ListDomainKindProperties). - Update rest of DomainKind implementations to use JSONObject (instead of Map<String, Object>) so that it works with generified DomainKind (using Map<String, Object> did not work as desired with generics so resorted to using JSONObject). (In the future when we convert other DomainKinds, use the approach taken for Lists - see ListDomainKind.getTypeClass() & createDomain()).
- Added canUpdate check to DomainKind.validateOptions and some additional parameters - Fixed comments - Removed TODOs - Added some additional validations checks to SampleSetDomainKind.validateOptions
cnathe
approved these changes
Mar 10, 2020
|
|
||
| this.state = { | ||
| schemaName, | ||
| queryName, |
Contributor
There was a problem hiding this comment.
It doesn't look like schemaName or queryName are expected anymore or used in this component, so I believe they can be removed from the state interface. Looks like fetchSampleTypeDomain is only using the domainId now.
Member
|
I opened an issue to track problems arising from this refactor. |
…pply if being created from a template
…omain update errors - DomainDesignerTest.testUserWarningOnRequiredFieldWithEmptyValues failed when trying to verify error message from setting a required field that has empty values in the domain
…the domain fields property names - SampleSetParentColumnTest.testAliasNameConflictsWithFieldName fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.