Kanban 1743: add the S3 SDK to the embedded server - #1500
Open
labkey-willm wants to merge 1 commit into
Open
Conversation
cloudServices resolves the AWS SDK from the embedded classloader, so declaring s3 only in the module left S3Client missing at runtime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
The remote R runner stages each job's working directory through object storage, so the appserver needs the S3 SDK at runtime. It belongs in the embedded server rather than in the module: the AWS SDK loads from the embedded classloader, and two copies across that boundary is a LinkageError rather than a version conflict.
Related Pull Requests
Changes