snprc_ehr: Update node-sass, sass-loader#392
Merged
labkey-nicka merged 1 commit intodevelopfrom Jan 6, 2022
Merged
Conversation
labkey-jeckels
approved these changes
Jan 6, 2022
Contributor
|
@spamhurts Terry can you try this branch out to verify the sass upgrade doesn't affect any of your UIs. You will need to switch your server repo over to the branch with this same name. Linked in the description above |
spamhurts
reviewed
Jan 6, 2022
Collaborator
spamhurts
left a comment
spamhurts
left a comment
There was a problem hiding this comment.
The changes don't appear to be causing any issues in the snprc_ehr module. All Jest tests and snapshots are reporting OK.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
This PR is a part of our update to get Node 16 and npm 8. This module needed to be updated due to failed compilation with outdated versions of sass not working on Node 16.
Related Pull Requests
Changes
node-sassandsass-loaderpackages to a combination that is compatible with Node 16.