TargetedMS Test Fixess - #1114
Merged
Merged
Conversation
labkey-danield
requested review from
a team and
labkey-tchad
and removed request for
a team
September 22, 2025 15:34
Longer wait for page to load.
labkey-danield
changed the title
labkey-tchad
left a comment
labkey-tchad
left a comment
Member
There was a problem hiding this comment.
I don't see any reason to increase all of these timeouts. I don't think the failures we're seeing are going to be prevented by longer waits. An external server is just having issues.
Contributor
Author
Yeah, I've reverted most of the timeout changes. The only changes now are a few locators and using waitAndClickAndWait. If you still think these changes are not necessary I can close the PR. |
labkey-tchad
approved these changes
Sep 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Some minor clean up.
Trying to address the failure in PassportTest.testSteps. This may be related to the current flakiness with external API calls to EBI (example: https://www.ebi.ac.uk/proteins/api/features/P02774 returns a 500), but waiting for the elements may not be a bad thing.
Related Pull Requests
Changes