Exclude close parens from name expression default value#2436
Merged
labkey-susanh merged 2 commits intodevelopfrom May 2, 2025
Merged
Exclude close parens from name expression default value#2436labkey-susanh merged 2 commits intodevelopfrom
labkey-susanh merged 2 commits intodevelopfrom
Conversation
XingY
approved these changes
May 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Close parens are problematic for default values since they are seen as closing the
defaultValue()expression. When entered through the UI, we correctly show an error message. This PR excludes the close paren from the valid characters for the testing of the default value.Changes
SampleTypeNameExpressionTestto remove close parens