Skip to content

Exclude close parens from name expression default value #2436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
labkey-susanh merged 2 commits into from
May 2, 2025
+1 −1
Merged

Exclude close parens from name expression default value #2436

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5722e21
Exclude close parens from name expression default value
labkey-susanh Apr 30, 2025
bd151f1
Merge remote-tracking branch 'origin/develop' into fb_nameExprTestFix
labkey-susanh May 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/org/labkey/test/tests/SampleTypeNameExpressionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
public class SampleTypeNameExpressionTest extends BaseWebDriverTest
{
private static final String PROJECT_NAME = "SampleType_Name_Expression_Test";
private static final String DEFAULT_SAMPLE_PARENT_VALUE = "SS" + TestDataGenerator.randomString(3).replaceAll("_", "."); // '_' is used as delimiter to get batchRandomId
private static final String DEFAULT_SAMPLE_PARENT_VALUE = "SS" + TestDataGenerator.randomString(3).replaceAll("[_)]", "."); // '_' is used as delimiter to get batchRandomId and ) is used to close the defaultValue()

private static final String PARENT_SAMPLE_TYPE = "PS" + DOMAIN_TRICKY_CHARACTERS;
private static final String PARENT_SAMPLE_TYPE_INPUT = "PS" + getEscapedNameExpression(DOMAIN_TRICKY_CHARACTERS);
Expand Down