Have tests wait for app content#499
Merged
labkey-tchad merged 4 commits intodevelopfrom Oct 14, 2020
Merged
Conversation
labkey-tchad
requested review from
a team,
labkey-ankurj,
labkey-chrisj,
labkey-danield,
labkey-nicka and
labkey-sweta
and removed request for
a team
labkey-ankurj
approved these changes
Oct 13, 2020
Contributor
labkey-ankurj
left a comment
labkey-ankurj
left a comment
There was a problem hiding this comment.
This looks good, I was adding waits in fbs for the cases.
Thanks,
Ankur
labkey-chrisj
approved these changes
Oct 14, 2020
Contributor
labkey-chrisj
left a comment
labkey-chrisj
left a comment
There was a problem hiding this comment.
It may be worth wrapping an error page up into its own page class eventually, but this is good
labkey-danield
approved these changes
Oct 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Now that error pages are a special single-page app, tests need to know how to wait for them to load. Several tests have been failing because an expected error wasn't present soon enough. Waiting for such errors on a case-by-case basis isn't a viable solution because we need to notice them when they aren't expected (especially in the Crawler).
Changes