Fixes for test refactors#503
Merged
labkey-tchad merged 1 commit intodevelopfrom Oct 21, 2020
Merged
Conversation
Increase timeout for app loading Properly escape backslashes in `Locator.cq` Give a less misleading error message for non-injection crawler errors
labkey-tchad
requested review from
a team,
labkey-chrisj,
labkey-danield and
labkey-sweta
and removed request for
a team
labkey-danield
approved these changes
Oct 21, 2020
cnathe
added a commit
that referenced
this pull request
Jan 6, 2026
…designer UI (LabKey Issue: 54178) (#2831) - Selenium test updates to check for link/href target when set via field editor or XML metadata
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Error pages sometimes take more than 5 seconds to render. The performance of these pages seems fine in reality and the failures on TeamCity are probably a side-effect of hammering so many links so rapidly.
This also includes a Locator fix and a better error message when the crawler hits certain errors when attempting script injection; these are usually just the server not handling the bad input well, not any actual vulnerability.
Related Pull Requests
Changes
Locator.cq(previous refactor was incorrect)