protect per-user event namespace and notify grantees on share - #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$DB/u/#read-only rule so publishes to the per-user event namespace are blocked unconditionally, not only when--scoped-eventsis on (closes scoped events: $DB/u/# namespace unprotected when --scoped-events is off #84); the internal service still publishes there, and the cross-user subscribe restriction stays flag-gated--scoped-eventsby treating a_sharesevent's recipient as its grantee, so a client learns of gained/lost access without polling (closes scoped events: grantee not notified when a resource is shared or unshared #85); with scoped events off,_sharesevents stay admin-only as beforeTest plan
$DB/u/#publish blocked, subscribe allowedevent_recipientsreturns the grantee for a_sharesevent, and empty (not broadcast) for an unresolved grantee