Skip to content

Conversation

@mnoszczak
Copy link
Contributor

@mnoszczak mnoszczak commented Oct 17, 2023

Makes the types more correct

@mnoszczak mnoszczak requested review from a team, apollonin and vbrodsky October 17, 2023 12:45
Copy link
Contributor

@kopreschko kopreschko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@vbrodsky vbrodsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@vbrodsky vbrodsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also here we have a default None, so Optional is not required:
https://docs.python.org/3/library/typing.html#typing.Optional

@mnoszczak
Copy link
Contributor Author

@vbrodsky:

PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True. Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebasemypynote

self,
from_cursor: str = None,
where: Comparison = None,
from_cursor: Optional[str] = None,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is tricky, but correct change I believe, based on https://docs.python.org/3/library/typing.html#typing.Optional

@mnoszczak mnoszczak merged commit 82373e9 into develop Oct 27, 2023
@mnoszczak mnoszczak deleted the mno/sdk-239 branch October 27, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants