Skip to content

[SDK-239] Fix dataset types #1262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2023
Merged

[SDK-239] Fix dataset types #1262

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions labelbox/schema/dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,8 @@ class Dataset(DbObject, Updateable, Deletable):

def data_rows(
self,
from_cursor: str = None,
where: Comparison = None,
from_cursor: Optional[str] = None,
Copy link
Contributor

@vbrodsky vbrodsky Oct 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is tricky, but correct change I believe, based on https://docs.python.org/3/library/typing.html#typing.Optional

where: Optional[Comparison] = None,
) -> PaginatedCollection:
"""
Custom method to paginate data_rows via cursor.
Expand Down