feat: add loading skeleton distinct from not-found state to stream details page (Closes #1088) - #1155
Merged
ogazboiz merged 3 commits intoAug 3, 2026
Conversation
ogazboiz
approved these changes
Aug 3, 2026
ogazboiz
left a comment
Contributor
There was a problem hiding this comment.
nice work. the structured skeleton mirrors the page layout with role=status and a proper aria-label, the not-found state stays distinct, and the four transition tests (pending to skeleton, success, 404) are exactly the right coverage for #1088. green after rebase. merging. if you want to keep contributing, join us on Telegram: https://t.me/+DOylgFv1jyJlNzM0
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1088
Summary
animate-pulseshimmer placeholders styled to match the dark themeAlertTriangleicon — no risk of confusing the two statesrole="status"andaria-labelfor accessibilityTesting