fix(backend): round owed amounts via half-even policy in loanController.ts roundToCents (#1372) - #1585
Merged
ogazboiz merged 9 commits intoAug 10, 2026
Conversation
…er.ts roundToCents (LabsCrypt#1372)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Use money policy half-even rounding in loanController roundToCents (#1372)
Description
Fixes issue #1372, where
roundToCentsinbackend/src/controllers/loanController.tspreviously usedMath.floor, causing owed amounts and amortization portions to be systematically floored down (undercharging borrowers/protocol).Replacing
Math.floorwith standardMath.roundwould have violated the repository's money policy (backend/src/money/policy.generated.ts), which defineshalf_even(banker's rounding) for settlement and balance calculations.This PR delegates cent rounding to the central money module (
backend/src/money/decimal.ts) usinghalf_eventie-breaking.Key Changes
backend/src/money/decimal.ts):roundToCents(value: number, mode?: RoundingMode)helper which converts floating point values into stroops (toStroops) and divides by100_000nusingroundDivunderhalf_evenmode.backend/src/controllers/loanController.ts):Math.floorimplementation ofroundToCentswith the money policy'shalf_evenroundToCentsfunction.backend/src/__tests__/roundToCents.test.tsand updatedbackend/src/money/__tests__/decimal.test.tsto cover.5tie-breaking half-even scenarios (e.g.,0.125→0.12,0.135→0.14,10.005→10.00,-0.125→-0.12).jestglobals import inbackend/src/__tests__/loanConfig.test.ts.Pull Request Checklist
CONTRIBUTING.mddocument.Verification
Executed local suite verifications: