Fix/code review hal serialization#14
Merged
Merged
Conversation
- BLEWriteDevice.write()/shutdown() now share the lock, and write() refuses to run or reconnect after shutdown -- prevents a late/queued write from re-arming a stimulator right after an emergency stop - BaseDevice.execute_action() gates on _initialized so a shut-down device cannot be driven again until re-initialized - TelemetrixBoard: offload blocking thread start/stop and set_pin_mode off the qasync event loop; serialize connect/disconnect with a lock; auto-reconnect on passive (mid-session) disconnect; clear stale pin caches on every disconnect path - PiGPIOBoard.emergency_stop() skips input devices (no read-only-value AttributeError spam) - HardwareManager: bound device.shutdown() with a timeout in disconnect_board()/shutdown_device(), matching emergency_stop() Adds tests/unit/hal/test_base_device.py, test_pi_gpio_board.py and tests/unit/core/test_hardware_manager.py.
- ExperimentSerializer read device.pin/.board_id/.settings, none of which exist on BaseDevice, so every device serialized as pin=0/board_id="" and failed to reload; now reads device._config.pins/.board.id/._config.settings - reload routes through add_device_multi_pin; zero-pin devices (e.g. the BLE stimulator) round-trip correctly - apply_to_session now syncs the loaded schema into the session model, with phantom-node filtering, so File > Save As after a load no longer overwrites the hardware map and flow graph with empty lists - DeviceConfigSchema carries a pins dict; single-pin saves emit both keys so they stay readable by older versions (zero/multi-pin is an accepted break) - ExperimentSession.remove_board() removes flow nodes bound to the removed board's devices, mirroring remove_device() - GliderCore retains fire-and-forget tasks in a set and drains them on shutdown so flow-teardown cannot be GC'd or race the shutdown path Adds tests/unit/core/test_background_tasks.py.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.