spam Insert Item in map-server log

[AlShammari1976]

what causing this message "[map][debug] ItemContainer: Container is full (InsertItem:145)" to repeatedly be logged on map server?!
I noticed happens when i threw an item from my inventory.

Note: vanilla LSB , just using commands around.

[WinterSolstice8]

Not sure, you'd have to add a breakpoint here

server/src/map/item_container.cpp

Line 145 in 8d09685

ShowDebug("ItemContainer: Container is full");

then give us the call stack after triggering the error. I had a hunch that it might be Recycle Bin but I tried enabling/disabling it and I didn't see the error.

[AlShammari1976]

thank you found it. in line 2904 of charutils.cpp, they try to insert then check for error.
I fixed it by deleting that line and change the if condition to check if there are free slot in that container and put the insert inside the if block.
Also needed to fix the 2 insertitem functions in item_container.cpp.

[WinterSolstice8]

This was fixed in #9870 which was approved (2x) but not merged so I merged it.

[AlShammari1976]

thank you very much. Updated my servers.
I'm so noob with github things and keeping up with updates, but reaching there.