[lua] Implement ELEMENTAL_DEBUFF_EFFECT#7521
Merged
Xaver-DaRed merged 1 commit intoLandSandBoat:basefrom May 2, 2025
Merged
Conversation
261c3fb to
433b8b5
Compare
Xaver-DaRed
approved these changes
May 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
Implements the ELEMENTAL_DEBUFF_EFFECT item mod on items such as the Archmage's Sabots +3 and Agwu's Slops. This mod adds additional potency to spells such as Burn and Frost.
This PR also reorganizes some item mods from the "not implemented" section to their associated job section in the enum files.
Steps to test these changes
!changejob BLM 99
!additem 23780 (Agwu's Slops, elemental debuff effect +5)
Cast the spell Burn on a mob, and observe the amount of stat reduction and DoT (place a print in scripts/effects/burn.lua, inside onEffectGain). Once it wears off, equip the Agwu's Slops and cast Burn again. You should see the DoT go up by 5, and the stat reduction go up by 10. The item also has a sizable bonus to INT, so you may bump up to the next dINT tier and see +1 potency than you'd normally expect (+1 DoT and +2 stat reduction).