Skip to content

[lua] Implement ELEMENTAL_DEBUFF_EFFECT#7521

Merged
Xaver-DaRed merged 1 commit intoLandSandBoat:basefrom
wccbuck:implement_ele_debuff_effect
May 2, 2025
Merged

[lua] Implement ELEMENTAL_DEBUFF_EFFECT#7521
Xaver-DaRed merged 1 commit intoLandSandBoat:basefrom
wccbuck:implement_ele_debuff_effect

Conversation

@wccbuck
Copy link
Copy Markdown
Contributor

@wccbuck wccbuck commented May 2, 2025

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Implements the ELEMENTAL_DEBUFF_EFFECT item mod on items such as the Archmage's Sabots +3 and Agwu's Slops. This mod adds additional potency to spells such as Burn and Frost.

This PR also reorganizes some item mods from the "not implemented" section to their associated job section in the enum files.

Steps to test these changes

!changejob BLM 99
!additem 23780 (Agwu's Slops, elemental debuff effect +5)

Cast the spell Burn on a mob, and observe the amount of stat reduction and DoT (place a print in scripts/effects/burn.lua, inside onEffectGain). Once it wears off, equip the Agwu's Slops and cast Burn again. You should see the DoT go up by 5, and the stat reduction go up by 10. The item also has a sizable bonus to INT, so you may bump up to the next dINT tier and see +1 potency than you'd normally expect (+1 DoT and +2 stat reduction).

@wccbuck wccbuck force-pushed the implement_ele_debuff_effect branch from 261c3fb to 433b8b5 Compare May 2, 2025 17:30
@Xaver-DaRed Xaver-DaRed merged commit 80c1e58 into LandSandBoat:base May 2, 2025
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants