Skip to content

[lua] Implement ELEMENTAL_DEBUFF_EFFECT #7521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Xaver-DaRed merged 1 commit into from
May 2, 2025
Merged

[lua] Implement ELEMENTAL_DEBUFF_EFFECT #7521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions scripts/enum/mod.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,6 +471,8 @@ xi.mod =
AUGMENTS_IMPETUS = 1097, -- see https://www.bg-wiki.com/ffxi/Impetus, adds Crit Hit Damage & Accuracy for Impetus

-- Black Mage
ENHANCES_ELEMENTAL_SEAL = 1149, -- Bonus magic damage when using Elemental Seal (percent)
ELEMENTAL_DEBUFF_EFFECT = 1150, -- Increase stat reduction by N, and DoT by N/2 HP per tick

-- Paladin
ENHANCES_CHIVALRY = 1061, -- Enhances "Chivalry" effect (increases the base TP modifier by the provided value / 100, e.g. mod value 5 = +0.05)
Expand Down Expand Up @@ -516,6 +518,7 @@ xi.mod =

-- Ninja
ENHANCES_SANGE = 1091, -- 1 = +1 attack for Daken during Sange per Sange merit (i.e. 20 with 5 merits = +100 attack during Sange)
ENHANCES_FUTAE = 1148, -- Adds to the +50% bonus damage to elemental ninjutsu provided by Futae (percent)

-- Dragoon
WYVERN_LVL_BONUS = 1043, -- Wyvern: Lv.+ (Increases wyvern's base level above 99)
Expand Down Expand Up @@ -1049,9 +1052,6 @@ xi.mod =
PARRY_HP_RECOVERY = 1135, -- Recover <Mod Value> HP on successful parry.

-- TODO: These mods are not yet implemented.
ENHANCES_FUTAE = 1148, -- TODO: Adds to the +50% bonus damage to elemental ninjutsu provided by Futae (percent)
ENHANCES_ELEMENTAL_SEAL = 1149, -- TODO: Bonus magic damage when using Elemental Seal (percent)
ELEMENTAL_DEBUFF_EFFECT = 1150, -- TODO: Increase stat reduction by +N, and DoT by N/2 HP per tick
ENF_MAG_DURATION = 1151, -- TODO: Increase enfeebling spell duration (percent)
REWARD_RECAST = 1152, -- TODO: Reduces Reward recast time (seconds)
AUGMENTS_ABSORB_TP = 1153, -- TODO: Increases absorb-TP potency, stacks with AUGMENTS_ABSORB
Expand Down
2 changes: 1 addition & 1 deletion scripts/globals/spells/enfeebling_spell.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ local function getElementalDebuffPotency(caster, statUsed)
potency = potency + 1
end

potency = potency + caster:getMerit(xi.merit.ELEMENTAL_DEBUFF_EFFECT) -- TODO: Add BLM Toban gear effect (potency) here.
potency = potency + caster:getMerit(xi.merit.ELEMENTAL_DEBUFF_EFFECT) + caster:getMod(xi.mod.ELEMENTAL_DEBUFF_EFFECT) / 2

return potency
end
Expand Down
18 changes: 9 additions & 9 deletions src/map/modifier.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,9 +432,11 @@ enum class Mod
REGEN_BONUS = 989, // Increases the amount of HP restored by Regen

// Black Mage
CLEAR_MIND = 295, // Used in conjunction with HEALMP to increase amount between tics
CONSERVE_MP = 296, // Percent chance
ELEMENTAL_MAGIC_RECAST = 1146, // Recast time for elemental magic spells (percent, usually negative)
CLEAR_MIND = 295, // Used in conjunction with HEALMP to increase amount between tics
CONSERVE_MP = 296, // Percent chance
ELEMENTAL_MAGIC_RECAST = 1146, // Recast time for elemental magic spells (percent, usually negative)
ENHANCES_ELEMENTAL_SEAL = 1149, // Bonus magic damage when using Elemental Seal (percent)
ELEMENTAL_DEBUFF_EFFECT = 1150, // Increase stat reduction by N, and DoT by N/2 HP per tick

// Red Mage
BLINK = 299, // Tracks blink shadows
Expand Down Expand Up @@ -578,6 +580,7 @@ enum class Mod
DAKEN = 911, // chance to throw a shuriken without consuming it
NINJUTSU_DURATION = 1000,
ENHANCES_SANGE = 1091, // 1 = +1 attack for Daken during Sange per Sange merit (i.e. 20 with 5 merits = +100 attack during Sange)
ENHANCES_FUTAE = 1148, // Adds to the +50% bonus damage to elemental ninjutsu provided by Futae (percent)

// Dragoon
ANCIENT_CIRCLE_DURATION = 859, // Ancient Circle extended duration in seconds
Expand Down Expand Up @@ -1085,12 +1088,9 @@ enum class Mod
PARRY_HP_RECOVERY = 1135, // Recover <Mod Value> HP on successful parry.

// TODO: These mods are not yet implemented.
ENHANCES_FUTAE = 1148, // TODO: Adds to the +50% bonus damage to elemental ninjutsu provided by Futae (percent)
ENHANCES_ELEMENTAL_SEAL = 1149, // TODO: Bonus magic damage when using Elemental Seal (percent)
ELEMENTAL_DEBUFF_EFFECT = 1150, // TODO: Increase stat reduction by +N, and DoT by N/2 HP per tick
ENF_MAG_DURATION = 1151, // TODO: Increase enfeebling spell duraiton (percent)
REWARD_RECAST = 1152, // TODO: Reward recast time reduction (seconds)
AUGMENTS_ABSORB_TP = 1153, // TODO: Increases absorb-TP potency, stacks with AUGMENTS_ABSORB
ENF_MAG_DURATION = 1151, // TODO: Increase enfeebling spell duration (percent)
REWARD_RECAST = 1152, // TODO: Reward recast time reduction (seconds)
AUGMENTS_ABSORB_TP = 1153, // TODO: Increases absorb-TP potency, stacks with AUGMENTS_ABSORB

// IF YOU ADD ANY NEW MODIFIER HERE, ADD IT IN scripts/enum/mod.lua ASWELL!

Expand Down