Merged
Conversation
mwislek
approved these changes
Apr 20, 2022
Contributor
mwislek
left a comment
mwislek
left a comment
There was a problem hiding this comment.
Looks good. I assume that the documentation generator updated all of those "table of contents" links, not you. Otherwise, we might look at changing the way that works.
chawes13
added a commit
that referenced
this pull request
Apr 25, 2022
* chore: upgrade node, bourbon, bourbon-neat and node-sass * chore: upgrade loaders to latest versions * fix: update SCCS to compile with new versions of node-sccs * chore: upgrade lp-hoc, classnames, cleave.js, filter-invalid-dom-props, lodash, moment, prop-types, react-color, react-modal, react-switch * chore: upgrade redux-flash * chore: upgrade all babel-related dependencies * chore: upgrade documentation * chore: upgrade react * chore: update package version * chore: update package version * chore: document migrations * chore: upgrade react-switch * chore: upgrade size-limit * chore: upgrade husky, redux * chore: add husky configuration * chore: upgrade @launchpadlab/eslint-config * fix: remove storybook knobs; allow Node 14 * fix: correct package versions; add Node version documentation * fix: downgrade eslint to correct build error * Remove react router (#544) * Remove react-router * Update docs * Make linting stricter Co-authored-by: Conor <conor@launchpadlab.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #416
This has been on my todo list for a long time and felt like an appropriate inclusion with the modernization effort (especially given how old react-router@3 is).
Author Checklist