Skip to content

Modernize lp-components#543

Merged
chawes13 merged 21 commits intomasterfrom
modernize-lp-components
Apr 25, 2022
Merged

Modernize lp-components#543
chawes13 merged 21 commits intomasterfrom
modernize-lp-components

Conversation

@mwislek
Copy link
Copy Markdown
Contributor

@mwislek mwislek commented Apr 7, 2022

This PR adds Node 16 support to lp-components. Additionally many of this module's dependencies were updated to the appropriate compatible version. Note the following updates were not made and should be addressed by future PRs:

  • While the storybook dependencies were updated, the files used to configure storybook will soon be deprecated. That should be addressed along with a upgrade to a storybook version that supports web pack ^5.0.0.
  • The "knobs" plug-in for storybook was deprecated and should be replaced with "controls".
  • react-router was not upgraded. The support for before/change hooks used in AuthorizedRoute and UnauthorizedRoute components is obsolete and should be refactored, like using React hooks (useEffect())
  • DateInput was not upgraded. This component uses moment under the hood. Newer versions of react-datepicker eliminate moment for date-fns. The selected prop should be updated to accept a JS Date rather than a moment().
  • The Babel upgrade causes a lot of warnings to be generated when yarn storybook is run. Several different attempts were made to resolve these warnings. These warnings should be corrected if/when the underlying babel-preset is upgraded and the storybook configuration mechanisms are updated.
  • An attempt was made to upgrade jest but that failed. The current use of mount() seems to require a JSDOM installation.

Author Checklist

  • Add unit test(s). No tests were added for this PR. Instead, the existing test suite was executed to verify that no errors were introduced.
  • Update version in package.json (see the versioning guidelines). Given that support for earlier Node versions was eliminated, this version is considered a MAJOR release.
  • Update documentation (if necessary), Added migration information.
  • Add story to storybook (if necessary) Note: not necessary.
  • Assign dev reviewer

Comment thread .storybook/addons.js Outdated
Comment thread .storybook/styles/application.scss
Comment thread .storybook/webpack.config.js
Comment thread migration-guides/v6.0.0.md
Comment thread package.json Outdated
Comment thread .husky/pre-commit
Comment thread .nvmrc
Comment thread .size-limit.js
Comment thread test/setup.js
@mwislek mwislek requested a review from chawes13 April 7, 2022 23:25
Comment thread .storybook/addons.js Outdated
Comment thread package.json Outdated
Comment thread package.json Outdated
Comment thread package.json Outdated
Comment thread package.json Outdated
Comment thread package.json Outdated
Comment thread package.json Outdated
@chawes13 chawes13 linked an issue Apr 19, 2022 that may be closed by this pull request
* Remove react-router

* Update docs
Copy link
Copy Markdown
Contributor

@chawes13 chawes13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@chawes13 chawes13 merged commit 9f817c1 into master Apr 25, 2022
@chawes13 chawes13 deleted the modernize-lp-components branch April 25, 2022 13:09
@chawes13 chawes13 mentioned this pull request Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade to latest supported Node versions

2 participants