Conversation
…s, lodash, moment, prop-types, react-color, react-modal, react-switch
mwislek
commented
Apr 7, 2022
mwislek
commented
Apr 7, 2022
mwislek
commented
Apr 7, 2022
mwislek
commented
Apr 7, 2022
mwislek
commented
Apr 7, 2022
mwislek
commented
Apr 7, 2022
mwislek
commented
Apr 7, 2022
mwislek
commented
Apr 7, 2022
mwislek
commented
Apr 7, 2022
chawes13
reviewed
Apr 18, 2022
chawes13
reviewed
Apr 19, 2022
* Remove react-router * Update docs
5 tasks
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds Node 16 support to lp-components. Additionally many of this module's dependencies were updated to the appropriate compatible version. Note the following updates were not made and should be addressed by future PRs:
storybookdependencies were updated, the files used to configurestorybookwill soon be deprecated. That should be addressed along with a upgrade to astorybookversion that supportsweb pack^5.0.0.storybookwas deprecated and should be replaced with "controls".react-routerwas not upgraded. The support for before/change hooks used inAuthorizedRouteandUnauthorizedRoutecomponents is obsolete and should be refactored, like using React hooks (useEffect())DateInputwas not upgraded. This component usesmomentunder the hood. Newer versions ofreact-datepickereliminatemomentfordate-fns. Theselectedprop should be updated to accept a JSDaterather than amoment().yarn storybookis run. Several different attempts were made to resolve these warnings. These warnings should be corrected if/when the underlyingbabel-presetis upgraded and thestorybookconfiguration mechanisms are updated.jestbut that failed. The current use ofmount()seems to require a JSDOM installation.Author Checklist