Surface events_lost, and gitignore the installer's credential backups - #34
Merged
Conversation
Two loose ends. events_lost was added in PR #32 but nothing ever read it: store_get_stats() has exactly one caller, at shutdown, and that log line did not include the field. The counter existed and was invisible. Print it, and when it is non-zero say separately what it means — it is the one number there that says miners are owed work the ledger has no record of. The ERROR at the moment of loss remains the primary signal; this makes the run total visible rather than dead weight. Second: .gitignore has /proxy.conf, which does not match the proxy.conf.bak.<timestamp> files the installer writes beside it on every run. Those carry bitcoind RPC credentials, this repo is public, and four had already accumulated in the working tree. The runbook has flagged the missing .gitignore line as "the proper fix" since the incident; this is it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small loose ends, both verified rather than assumed.
events_lostwas a dead counterPR #32 added it, but nothing reads it.
store_get_stats()has exactly one caller — at shutdown — and that log line didn't include the field:So the counter existed and was invisible. Now it's printed, and when non-zero it also gets its own line saying what it actually means: miners are owed work the ledger has no record of.
The
LOSTERROR at the moment of loss is still the primary signal — this just stops the run total being dead weight.The installer's credential backups still weren't ignored
.gitignorehas/proxy.conf, which does not matchproxy.conf.bak.<timestamp>— the files the installer writes beside it on every run. They contain the bitcoind RPC password, this repo is public, and four had already accumulated in the working tree, onegit add -Afrom being committed.The runbook has listed a
.gitignoreline as "the proper fix" since that was found. This is it. Verified:makeclean under-Werror.