Demote the per-submit SUBMIT CHECK dump from INFO to DEBUG - #71
Merged
Merged
Conversation
Vardiff clamps the share target to the network target, so at difficulty 1 every miner submits at its full hash rate. At ~287 TH/s that is roughly 66,800 submits a second, and this line emits five journal lines for each. journald's default rate limit is 10,000 messages per 30 s (~333/s). Two orders of magnitude over it means journald starts dropping, and the pool's own INFO-level fault signals go down with the noise: 'settled block', 'had no payout plan', 'no shares in the window' and 'window has no payable addresses' are all LOG_INFO. The monitoring would have read green while blind, in the one window it exists for. Demoting it also removes the work: two of the three hex conversions exist only for this line and are now skipped with it. sent_hash_hex stays unconditional because the share record below needs it. Adds log_enabled() so a caller can skip log-only work. All 8 suites pass (test_stratum 134).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every share submission logs a multi-line
SUBMIT CHECKblock at INFO. At share rate that is the dominant thing in the journal, and it buries the lines an operator actually needs — authorize, vardiff retargets, block candidates, rejects.It is genuinely useful when diagnosing a single miner, so this demotes it to DEBUG rather than removing it. Same information, available when asked for.
No behaviour change beyond log level. Full suite green on a clean checkout of
main.