[INT-419] Solana OApp Aptos compatibility patch - #1599
Merged
Conversation
…iguration updates - Updated README.md to clarify Solana wiring instructions and added a note on deployment requirements. - Modified aptos-move-send.ts to correct environment variable names and update message content. - Introduced new Aptos configuration files and tasks for improved integration. - Added documentation for wiring Solana to Move-VM, including detailed deployment steps. - Implemented Aptos SDK factory and signer factory for better handling of Aptos transactions.
…tion - Set OApp address for Aptos and updated destination chain endpoint ID to Solana. - Enhanced message preparation logic to handle different network types, specifically for Solana. - Added length encoding for messages sent to Solana to ensure proper formatting.
AlexanderLiteplo
changed the title
ItsAdel
suggested changes
Jul 3, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
Enhance Solana OApp integration with Move-VM by adding Aptos support, updating configurations, and refining example scripts.
- Added detailed wiring documentation and unified configuration templates for Solana → Aptos.
- Introduced Aptos SDK and signer factories in the oapp-solana tasks suite.
- Corrected environment variable names and extended message packaging logic in the Aptos Move send script.
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| examples/oft-solana/docs/wiring-to-aptos.md | New guide for wiring Solana contracts to Aptos Move-VM |
| examples/oft-solana/docs/move.layerzero.config.ts | Example Solana→Aptos config template |
| examples/oft-solana/docs/Aptos.md | Removed obsolete Aptos doc |
| examples/oapp-solana/tasks/common/wire.ts | Integrated Aptos signer factory into wire task |
| examples/oapp-solana/tasks/common/utils.ts | Added Aptos SDK factory support |
| examples/oapp-solana/tasks/aptos/ | New Aptos signer/SDK factories and endpoint stubs |
| examples/oapp-aptos-move/scripts/aptos-move-send.ts | Fixed env var names and added Solana message packaging |
| examples/oapp-aptos-move/README.md | Updated Solana wiring instructions in README |
Comments suppressed due to low confidence (2)
examples/oft-solana/docs/move.layerzero.config.ts:13
- [nitpick] Placeholder 'YOUR_DEPLOYED_APTOS_OFT_ADDRESS' differs from 'YOUR_DEPLOYED_APTOS_CONTRACT_ADDRESS' used elsewhere; consider unifying the placeholder name for consistency.
address: 'YOUR_DEPLOYED_APTOS_OFT_ADDRESS',
examples/oapp-solana/tasks/aptos/aptosSignerFactory.ts:11
- [nitpick] Consider adding unit tests for the Aptos signer factory to verify its behavior with valid and invalid EIDs.
export function createAptosSignerFactory(): (
…iguration - Updated OApp address and changed destination chain endpoint ID to Solana in aptos-move-send.ts. - Simplified message preparation logic for Solana using ethers.js for better readability and efficiency. - Enhanced README.md to clarify instructions for wiring Move-VM OFT to Solana, including updated code snippets.
EWCunha
approved these changes
Jul 4, 2025
EWCunha
left a comment
EWCunha
left a comment
Contributor
There was a problem hiding this comment.
Nice job, Alexander! You deserve a raise. Or at least a really enthusiastic thumbs-up. 👍
shankars99
pushed a commit
that referenced
this pull request
Jul 20, 2025
mattsse
pushed a commit
to mattsse/devtools
that referenced
this pull request
Aug 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance Solana to Move-VM integration with new Aptos support and configuration updates
Testing Transactions:
https://testnet.layerzeroscan.com/tx/0xa6b949891dac1a3f9bea653ba6008d33ef4bf8f87798bb46a7b70deb77abdc5c
https://testnet.layerzeroscan.com/tx/4m1q2cTTFrs6rEmWJXMhReb5Ra5b3sYz54uT6J6a9VMR2EYX6hf5SL9NoXf8XUSAzUefcrNaaRFKvKzCuN8mZqTA