feat: require docs check on sharp-mud, via per-repo override#3
Merged
Conversation
sharp-mud's docs workflow now always runs on PRs (skipping the real build fast when irrelevant) specifically so it's safe to require — see LayeredCraft/sharp-mud#12. Org-default contexts only list "build / build", so this repo needs its own override to add "docs" without affecting every other repo. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6e12ff3c76
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
safe-settings merges required_status_checks.contexts across org/repo levels by default (org-level contexts fold into repo-level, not replaced), so repeating build / build and the whole rest of the protection block here was redundant duplication of settings.yml — only the net-new "docs" context belongs in this file. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
safe-settings/repos/sharp-mud.yml, a per-repo branch-protection override (same pattern asdevops-templates.yml/dynamodb-efcore-provider.yml)docsalongside the org-defaultbuild / buildin required status checks forsharp-mud'smainbranchsettings.yml) is untouched, so no other repo is affectedDepends on LayeredCraft/sharp-mud#12, which makes the
docscheck always run (instead of path-filtered) so it's safe to require without permanently blocking non-docs PRs. Merge that first, or at least around the same time, so there's no window wheredocsis required but never posts a status.Test plan
docsas a required check🤖 Generated with Claude Code