ci(github): get NuGet package version from release tag#113
Merged
Conversation
Extract the version from the GitHub release tag instead of reading from Directory.Build.props. Pass the version to dotnet pack via MSBuild property to ensure published packages always match the release version. - Extract version from github.event.release.tag_name - Strip 'v' prefix if present (e.g. v1.0.0 -> 1.0.0) - Pass version to pack command via /p:VersionPrefix property - Simplify validation to focus on API key check
- Add a note referencing Conventional Commits for documentation standards - Include heading for v0.1.1 changes but remove redundant text
- Change release notes heading from "Changes in this Release" to "Summary" - Add placeholder for summary (SUMMARY_GOES_HERE) above changes section
- Add step to strip header and summary in update-changelog workflow - Use Perl script to clean up CHANGELOG content before committing
j-d-ha
changed the title
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #113 +/- ##
=======================================
Coverage 50.12% 50.12%
=======================================
Files 52 52
Lines 1640 1640
Branches 204 204
=======================================
Hits 822 822
Misses 765 765
Partials 53 53 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
📋 Summary
Updates the publish workflow to extract the NuGet package version from the GitHub release tag instead of reading from
Directory.Build.props. This ensures published packages always match the release version, eliminating version discrepancies and simplifying release management.✅ Checklist
🧪 Related Issues or PRs
Closes #...
💬 Notes for Reviewers
Key Changes:
github.event.release.tag_namevprefix if present (e.g.v1.0.0→1.0.0)dotnet packvia/p:VersionPrefixMSBuild propertyBenefits:
Testing: