Skip to content

fix: prevent example projects from being packed during release#115

Merged
j-d-ha merged 4 commits into
mainfrom
fix/make-publish-skip-example-projects
Nov 10, 2025
Merged

fix: prevent example projects from being packed during release#115
j-d-ha merged 4 commits into
mainfrom
fix/make-publish-skip-example-projects

Conversation

@j-d-ha

@j-d-ha j-d-ha commented Nov 10, 2025

Copy link
Copy Markdown
Collaborator

🚀 Pull Request

📋 Summary

This PR prevents example projects from being packed during the NuGet release process by setting <IsPackable>false</IsPackable> in all example project files. Additionally, it improves the regex pattern in the changelog workflow to handle versioned header formats with optional links and additional metadata.

Changes:

  • Added <IsPackable>false</IsPackable> to all example projects (HelloWorld, HelloWorldAot, Lifecycle, OpenTelemetry)
  • Updated the changelog regex in the workflow to support linked version headers with additional formatting
  • Updated CHANGELOG.md with release links

✅ Checklist

  • My changes build cleanly
  • I've followed the coding style for this project
  • The changes prevent example projects from being included in NuGet packages

🧪 Related Issues or PRs

Relates to release workflow and NuGet packaging


💬 Notes for Reviewers

The example projects are now properly excluded from NuGet packaging, which ensures that only the core library packages are published. The changelog regex improvement ensures compatibility with the newer link format used by the release notes generator.

Set IsPackable=false on all example projects to prevent them from being
included in the NuGet pack step during the release workflow. This prevents
403 Forbidden errors when trying to push sample packages to NuGet.org
without authorization.
- Added version comparison links for v0.1.1 and v0.1.2.
- Introduced an "Unreleased" section for tracking upcoming changes.
- Updated regex to support versions with links and parentheses in the changelog header.
- Ensures proper removal of headers and summary to maintain consistent formatting.
@github-actions github-actions Bot added the type: fix Bug fix label Nov 10, 2025
@codecov

codecov Bot commented Nov 10, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #115   +/-   ##
=======================================
  Coverage   50.12%   50.12%           
=======================================
  Files          52       52           
  Lines        1640     1640           
  Branches      204      204           
=======================================
  Hits          822      822           
  Misses        765      765           
  Partials       53       53           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a262dd6...ae78c38. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud

Copy link
Copy Markdown

@j-d-ha
j-d-ha merged commit bb08302 into main Nov 10, 2025
8 checks passed
@j-d-ha
j-d-ha deleted the fix/make-publish-skip-example-projects branch November 10, 2025 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant