fix(tui): dedupe @opentui/solid in Windows hoisted install - #90
Merged
Conversation
Stale nested lockfile entries (opentui-spinner/@opentui/{core,solid}@0.4.2)
caused Windows CI's --linker hoisted install to materialize a second copy
of @opentui/solid under opentui-spinner/node_modules. The bundle then held
two @opentui/solid instances with independent componentCatalogue modules:
opentui-spinner/solid's extend() registered 'spinner' into the 0.4.2 copy
while the app reconciler read the 0.4.3 catalogue, crashing with
'[Reconciler] Unknown component type: spinner'. Only Windows binaries were
affected; Linux/macOS use the isolated linker which symlinks the spinner's
peers to the shared 0.4.3 instance.
Removing the stale entries lets the spinner's peers dedupe to the single
0.4.3 instance under overrides. Verified via bun install --linker hoisted
--frozen-lockfile: no nested @opentui/solid copy is produced.
LeXwDeX
enabled auto-merge
July 9, 2026 02:57
This was referenced Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Windows builds crash at startup with a different error than before:
Only Windows binaries are affected; Linux/macOS are fine.
Root cause
opentui-spinnerdeclares peer deps@opentui/{core,solid}@^0.3.4, which don't satisfy our catalog0.4.3.bun.locktherefore carried stale nested resolution entries (opentui-spinner/@opentui/core@0.4.2,opentui-spinner/@opentui/solid@0.4.2, plus their platform/transitive deps) — despite the rootoverridespinningcatalog:(0.4.3).Windows CI is a special install path:
.github/actions/setup-bun/action.ymlrunsbun install --linker hoistedon Windows only (workaround for bun#28147). The hoisted linker materializes those stale entries as a real nested copynode_modules/opentui-spinner/node_modules/@opentui/solid(0.4.2). Linux/macOS use the default isolated linker, which symlinks the spinner's peers to the shared 0.4.3 — that's why only Windows breaks.The bundle then contains two copies of
@opentui/solid, each with an independent module-levelcomponentCatalogue:import "opentui-spinner/solid"callsextend({ spinner }), registeringspinnerinto the 0.4.2 copy's catalogue.[Reconciler] Unknown component type: spinner.Fix
Removed the 28 stale nested lockfile lines so
opentui-spinner's peers dedupe to the single 0.4.3 instance (as the rootoverridesalready intend).bun installre-resolves cleanly and does not regenerate them.Verification
bun installafter the edit: noopentui-spinner/@opentui/*nested entries recreated (lock diff = 28 deletions only).bun install --linker hoisted --frozen-lockfile: confirmed nonode_modules/opentui-spinner/node_modules/@opentui/solidnested copy is produced, and the single@opentui/solidis0.4.3.Scope
bun.lockonly — no source changes.This PR targets
dev(Typecheck gate). Follow-up: the next Windows build from this lockfile will carry the single-instance registration.