Dev - #7
Merged
Merged
Conversation
…Rust source builds
… Python 3.8 compatibility
…om breaking gRPC HTTP/2 stream
…e multiprocessing handling in edge/platform clients
…low cross-network access
… setuptools build error on older pip
…nment configuration and session state
…taller/macOS multiprocessing
AWS Beta Release
anurag2796
added a commit
that referenced
this pull request
Jul 14, 2026
…web JWT key
app.fl.token-secret defaults to app.jwt.secret (${APP_FL_TOKEN_SECRET:${app.jwt.secret}})
for local backward-compat. But the network-facing FL server holds the FL secret,
so if it equals the web-auth key a compromise of that server can forge web/admin
sessions — defeating the SE-7/SE-17 trust-domain isolation that keeps APP_JWT_SECRET
out of the FL child. A new FlSecretDistinctnessValidator fails the boot closed
(IllegalStateException) when a deployed profile (ec2demo/production) is active AND
the two secrets resolve equal; dev/test/base still allow the fallback.
This is the "boot check they differ" half of finding #7; the web-JWT audience/type
binding (defense-in-depth for a shared dev secret) touches the auth hot path and is
tracked as remaining. Unit-tested (deployed+equal -> throws; deployed+distinct and
non-deployed -> ok); full backend suite green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces major improvements to the build and release process for the FedLearn Desktop application, along with significant updates to the project documentation. The new workflow provides a unified, cross-platform build and release pipeline for macOS (Apple Silicon), Windows (CPU and CUDA), and Linux (x64 and arm64), automating the packaging of both the Electron frontend and the PyInstaller-built native client. The documentation is updated to reflect the current architecture, deployment, authentication flow, and technology stack, clarifying how all components interact and improving security explanations.
Build & Release Automation:
.github/workflows/release-desktop.ymlto implement a matrix-based GitHub Actions workflow that builds, packages, and releases the Electron desktop app and native client for macOS (arm64), Windows (CPU and CUDA), and Linux (x64, arm64), with artifact uploads and a detailed release description..github/workflows/desktop-release.ymlin favor of the new workflow, which offers broader platform support and a more robust, maintainable release process.Documentation & Architecture Updates:
README.mdsystem components table and data flow section to accurately describe the frontend, backend, database, FL framework, clients, and new desktop orchestrator, including deployment details and supported platforms.Clarity and Security Enhancements:
These changes streamline the release workflow, improve cross-platform support, and provide clearer, more secure documentation for both developers and end users.