Skip to content

Redesign for blocks screen#1718

Merged
dessalines merged 3 commits intoLemmyNet:mainfrom
rodrigo-fm:feature/blocks-redesign
Nov 18, 2024
Merged

Redesign for blocks screen#1718
dessalines merged 3 commits intoLemmyNet:mainfrom
rodrigo-fm:feature/blocks-redesign

Conversation

@rodrigo-fm
Copy link
Copy Markdown
Contributor

Pull request for #1712

Here's the new blocks screen:

Screenshot_20241108_231047

image

image

Comment thread app/src/main/res/values/strings.xml Outdated
Comment thread app/src/main/java/com/jerboa/datatypes/Others.kt Outdated
Comment thread app/src/main/java/com/jerboa/ui/components/settings/block/BlocksScreen.kt Outdated
@rodrigo-fm
Copy link
Copy Markdown
Contributor Author

I also centered the empty list message, now it'll show like this:

image

@rodrigo-fm
Copy link
Copy Markdown
Contributor Author

rodrigo-fm commented Nov 12, 2024

@MV-GH I feel that the PR seems ready to merge, but could you wait until I add the blocked elements count? So that we have this layout for the tabs as proposed in the issue? Users (3) | Communities (2) | Instances (0)

I just remembered it now

@MV-GH
Copy link
Copy Markdown
Collaborator

MV-GH commented Nov 12, 2024

Sure you can mark it draft

@rodrigo-fm rodrigo-fm marked this pull request as draft November 12, 2024 11:28
@dessalines
Copy link
Copy Markdown
Member

Looks good so far! Ping me or request a review when you're ready for that.

@rodrigo-fm
Copy link
Copy Markdown
Contributor Author

@MV-GH @dessalines I think I'll leave the PR as it is. I tried to add the blocks count to the tabs, but I wasn't able to display it in a horizontally scrollable interface, since the text was too constrained and caused a line break. I tried the ScrollableTabRow composable for this, but it wasn't using the screen's full width, which gave the tabs this incomplete line below them, causing them to have a weird design.

In the end I found this link showing how to reduce the internal padding from the Tabs inside the TabRow https://stackoverflow.com/questions/68949292/jetpack-compose-reducing-internal-padding-of-tabs, but I think it'll be better to leave it to another pull request, so that this one doesn't get too big or overcomplicated for an initially simple idea.

My goal with removing the padding is to avoid the scenario below:

image

@rodrigo-fm rodrigo-fm marked this pull request as ready for review November 18, 2024 00:07
@MV-GH
Copy link
Copy Markdown
Collaborator

MV-GH commented Nov 18, 2024

For counter changes, not so sure removing padding will be better. For the navigation bar we had to resort to making the text smaller.

But its not perfect, depending on language and phone size it can still fail.

Copy link
Copy Markdown
Member

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works well, thx!

@dessalines dessalines merged commit 6dd3bbd into LemmyNet:main Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants