Fixes #1755 Keyboard still open after creating comment

[MV-GH]

When sending the comment, it goes into "loading" mode, here the CommentReplyView leaves the composition, then when it receives response it goes into ApiState Success. Now the previous ReplyView enters composition again for short period. Where it asks for focus again. Thus the open keyboard state after creating a comment.

This fixes it by not showing the CommentReply view after sending. Thus it doesnt ask for focus.

Also removed the focus removal. It doesn't seem to do anything.

iCnpS6aRXf.mp4

The other screens aren't affected because they don't show a loading bar and hide the body. Thus it doesn't leave composition. :)

Fixes #1755

[Copilot]

Pull Request Overview

This PR fixes an issue where the keyboard remains visible after creating a comment by suppressing the re-entry of the CommentReply view and removing unnecessary focus removal calls.

• Modified the loading state to include ApiState.Success to maintain the loading UI briefly.
• Removed focus management code from multiple components and view models.
• Updated a DisposableEffect to LaunchedEffect for immediate focus handling in the MarkdownTextField.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
app/src/main/java/com/jerboa/ui/components/privatemessage/PrivateMessageReplyScreen.kt	Removed focus management and updated loading state logic.
app/src/main/java/com/jerboa/ui/components/common/InputFields.kt	Replaced DisposableEffect with LaunchedEffect for focus request.
app/src/main/java/com/jerboa/ui/components/comment/reply/CommentReplyScreen.kt	Removed focus manager parameter and adjusted loading state documentation.
app/src/main/java/com/jerboa/model/PrivateMessageReplyViewModel.kt	Removed unnecessary focus management call after message creation.
app/src/main/java/com/jerboa/model/CommentReplyViewModel.kt	Eliminated focus manager usage on comment success.

Comments suppressed due to low confidence (1)

app/src/main/java/com/jerboa/ui/components/common/InputFields.kt:165

• Ensure that replacing DisposableEffect with LaunchedEffect preserves the intended lifecycle behavior, especially concerning cleanup logic if needed in future changes.

LaunchedEffect(Unit) {

[dessalines]

Weird bug, I haven't gotten it on several devices.