README updates#2913
Merged
Merged
Conversation
…with wikipedia article. Commented out sponsor list as page DNE. Commented out Contributing section as all sites DNE. Added simple instructions for git contribution. Cleaned up formatting for Contributing section. TODO: update join-lemmy.org/docs, uncomment removed lines
Nutomic
reviewed
Jun 5, 2023
| - The old school [video game](<https://en.wikipedia.org/wiki/Lemmings_(video_game)>). | ||
| - The [Koopa from Super Mario](https://www.mariowiki.com/Lemmy_Koopa). | ||
| - The [furry rodents](http://sunchild.fpwc.org/lemming-the-little-giant-of-the-north/). | ||
| - The [furry rodents](https://en.wikipedia.org/wiki/Lemming). |
Member
There was a problem hiding this comment.
There is nothing wrong with this, a readonly page doesnt need https. And wikipedia is boring.
Contributor
Author
There was a problem hiding this comment.
fair enough - considering this is a git readme it's probably not for general users.
as a note, i feel that having links with security errors on public facing sites can definitely scare away new users however!
Nutomic
reviewed
Jun 5, 2023
| - [Support on Patreon](https://www.patreon.com/dessalines). | ||
| - [Support on OpenCollective](https://opencollective.com/lemmy). | ||
| - [List of Sponsors](https://join-lemmy.org/sponsors). | ||
| <!-- - [List of Sponsors](https://join-lemmy.org/sponsors). --> |
Member
There was a problem hiding this comment.
Dont comment it out but change to https://join-lemmy.org/donate
Nutomic
reviewed
Jun 5, 2023
| - [Local Development](https://join-lemmy.org/docs/en/contributing/local_development.html) | ||
| - [Local Development](https://join-lemmy.org/docs/en/contributing/local_development.html) --> | ||
|
|
||
| - In order to contribute to Lemmy, you will need to fork this repository. You can then make changes to the code and submit a pull request. Changes will be reviewed and merged into the main repository if accepted. |
Member
There was a problem hiding this comment.
Fix the links instead of commenting them out. Text should go directly in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced unsecure link on lemmings with a Wikipedia article.
Commented out some missing links, added simple git contribution instructions for the time being.
Note - Contributing.md is also currently broken