Fixing comment downvote after an upvote.#6370
Merged
Conversation
- The culprit was an incorrect on_conflict trigger, which needed to be converted to a `MERGE` to handle the multiple unique keys: (person_id, post_id) and (person_id, comment_id) - Fixes #6103
Collaborator
|
Be careful with merge, because it handles concurrency differently, and a transaction is not necessarily enough to make it work properly. I'm not totally sure if this merge statement is fine. I recommend adding a check that throws an error (which undoes the transaction) if the merge statement did not affect the correct number of rows, to avoid leaving inconsistent state in the database. |
Member
Author
|
Turns out I didn't need merge, just needed to change |
Nutomic
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MERGEto handle the multiple unique keys: (person_id, post_id) and (person_id, comment_id)PostActions::remove_likecall #6103