Conversation
dessalines
requested review from
Nutomic,
SleeplessOne1917,
dullbananas and
phiresky
as code owners
crates/diesel_utils/Cargo.toml
Outdated
| deadpool = { version = "0.12.3", features = ["rt_tokio_1"], optional = true } | ||
| deadpool-runtime = { version = "0.1.4", features = [ | ||
| "tokio_1", | ||
| ], optional = true } |
There was a problem hiding this comment.
Why switch the crate here? Readme says that it shouldnt be used directly.
https://github.com/deadpool-rs/deadpool/tree/main/crates/deadpool-runtime
There was a problem hiding this comment.
The upgraded diesel async needed it, only for a type definition for the runtime.
diesel async actually uses its own embedded deadpool in a feature, and the runtime is necessary when you use timeouts (its called unmanaged). Otherwise we could remove every deadpool dep and let diesel-async use a managed pool.
Anyways it works otherwise the tests would be failing.
There was a problem hiding this comment.
Usually that type should be reexported by diesel-async, but its not possible because diesel-async doesnt enable the tokio_1 feature for deadpool.
However I tried with deadpool as dependency instead and it works just fine (using version 0.12.3 and feature rt_tokio_1). Better keep using that instead of deadpool-runtime.
2 participants
No description provided.