hooks/13_login_form/fix function parameters#173
Merged
brauliodiez merged 2 commits intoLemoncode:masterfrom Mar 6, 2019
Merged
hooks/13_login_form/fix function parameters#173brauliodiez merged 2 commits intoLemoncode:masterfrom
brauliodiez merged 2 commits intoLemoncode:masterfrom
Conversation
maxfarseer
changed the title
maxfarseer
commented
Mar 6, 2019
| interface PropsForm { | ||
| onLogin: () => void; | ||
| onUpdateField: (string, any) => void; | ||
| onUpdateField: (name: string, value: any) => void; |
Contributor
Author
There was a problem hiding this comment.
Should it be value: string here?
Member
There was a problem hiding this comment.
It could be for this case you are right, we are passing an string (just don't wanted to tie it up, maybe another control could use another type)
Member
|
Thanks a lot, great catch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it's a typo, but there is forgotten parameters name before types