Skip to content

Fix dark inactive tab title visibility #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Leoncl2025 merged 1 commit into from
Sep 1, 2026
Merged

Fix dark inactive tab title visibility #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/DockedEditor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ DockedEditor::DockedEditor(QWidget *parent) : QObject(parent)
ads::CDockManager::setConfigFlag(ads::CDockManager::EqualSplitOnInsertion, true);
ads::CDockManager::setConfigFlag(ads::CDockManager::MiddleMouseButtonClosesTab, true);
ads::CDockManager::setConfigFlag(ads::CDockManager::DockAreaHasTabsMenuButton, false);
ads::CDockManager::setConfigFlag(ads::CDockManager::DisableStylesheet, true);

dockManager = new ads::CDockManager(parent);
dockManager->setStyleSheet("");
Expand Down
62 changes: 42 additions & 20 deletions tests/CompareSessionTests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,38 +166,60 @@ private slots:
QFile styleSheet(QStringLiteral(":/stylesheets/npp.css"));
QVERIFY(styleSheet.open(QIODevice::ReadOnly | QIODevice::Text));
const QByteArray css = styleSheet.readAll();
const QPalette originalPalette = QApplication::palette();
const auto restorePalette = qScopeGuard([originalPalette] {
QApplication::setPalette(originalPalette);
});

QPalette lightPalette = originalPalette;
lightPalette.setColor(QPalette::Window, Qt::white);
lightPalette.setColor(QPalette::WindowText, Qt::black);
lightPalette.setColor(QPalette::Base, Qt::white);
lightPalette.setColor(QPalette::Text, Qt::black);
QApplication::setPalette(lightPalette);

QWidget host;
QPalette darkPalette = host.palette();
host.resize(900, 600);
DockedEditor dockedEditor(&host);
dockedEditor.addEditor(new ScintillaNext(QStringLiteral("first.cpp")));
dockedEditor.addEditor(new ScintillaNext(QStringLiteral("second.cpp")));
dockedEditor.addEditor(new ScintillaNext(QStringLiteral("third.cpp")));
host.show();
QCoreApplication::processEvents();

QPalette darkPalette = lightPalette;
darkPalette.setColor(QPalette::Window, QColor(QStringLiteral("#191A1B")));
darkPalette.setColor(QPalette::WindowText, QColor(QStringLiteral("#BFBFBF")));
darkPalette.setColor(QPalette::Base, QColor(QStringLiteral("#121314")));
darkPalette.setColor(QPalette::Text, QColor(QStringLiteral("#BBBEBF")));
darkPalette.setColor(QPalette::PlaceholderText, QColor(QStringLiteral("#555555")));
host.setPalette(darkPalette);
host.resize(900, 600);

DockedEditor dockedEditor(&host);
dockedEditor.addEditor(new ScintillaNext(QStringLiteral("first.cpp")));
dockedEditor.addEditor(new ScintillaNext(QStringLiteral("second.cpp")));
darkPalette.setColor(QPalette::Light, QColor(QStringLiteral("#242526")));
QApplication::setPalette(darkPalette);
host.setStyleSheet(QString::fromUtf8(css)
+ DockedEditor::tabTitleStyleSheet(
QColor(QStringLiteral("#BFBFBF")), QColor(QStringLiteral("#8C8C8C"))));
host.show();
QCoreApplication::processEvents();

ads::CDockManager *dockManager = host.findChild<ads::CDockManager *>();
QVERIFY(dockManager != nullptr);
QVERIFY(dockManager->styleSheet().isEmpty());

const QList<ads::CDockWidgetTab *> tabs = host.findChildren<ads::CDockWidgetTab *>();
QCOMPARE(tabs.size(), 2);
auto inactive = std::find_if(tabs.cbegin(), tabs.cend(), [](const auto *tab) {
return !tab->isActiveTab();
});
QVERIFY(inactive != tabs.cend());

const QList<ads::CElidingLabel *> labels =
(*inactive)->findChildren<ads::CElidingLabel *>();
QCOMPARE(labels.size(), 1);
labels.first()->ensurePolished();
QCOMPARE(labels.first()->palette().color(QPalette::WindowText),
QColor(QStringLiteral("#8C8C8C")));
QCOMPARE(tabs.size(), 3);
int inactiveCount = 0;
for (ads::CDockWidgetTab *tab : tabs) {
if (tab->isActiveTab())
continue;

++inactiveCount;
const QList<ads::CElidingLabel *> labels =
tab->findChildren<ads::CElidingLabel *>();
QCOMPARE(labels.size(), 1);
labels.first()->ensurePolished();
QCOMPARE(labels.first()->palette().color(QPalette::WindowText),
QColor(QStringLiteral("#8C8C8C")));
}
QCOMPARE(inactiveCount, 2);
}

void navigationWrapsInBothDirections()
Expand Down