Skip to content

fix(release): merge develop into main#269

Merged
bedatty merged 2 commits intomainfrom
develop
Apr 24, 2026
Merged

fix(release): merge develop into main#269
bedatty merged 2 commits intomainfrom
develop

Conversation

@bedatty
Copy link
Copy Markdown
Contributor

@bedatty bedatty commented Apr 24, 2026

Lerian

GitHub Actions Shared Workflows


Description

Type of Change

  • feat: New workflow or new input/output/step in an existing workflow
  • fix: Bug fix in a workflow (incorrect behavior, broken step, wrong condition)
  • perf: Performance improvement (e.g. caching, parallelism, reduced steps)
  • refactor: Internal restructuring with no behavior change
  • docs: Documentation only (README, docs/, inline comments)
  • ci: Changes to self-CI (workflows under .github/workflows/ that run on this repo)
  • chore: Dependency bumps, config updates, maintenance
  • test: Adding or updating tests
  • BREAKING CHANGE: Callers must update their configuration after this PR

Breaking Changes

None.

Testing

  • YAML syntax validated locally
  • Triggered a real workflow run on a caller repository using @develop or the beta tag
  • Verified all existing inputs still work with default values
  • Confirmed no secrets or tokens are printed in logs
  • Checked that unrelated workflows are not affected

Caller repo / workflow run:

Related Issues

Closes #

Summary by CodeRabbit

  • Chores
    • Updated automated maintenance workflow triggers to remove pull-request event dependencies, retaining only scheduled execution and manual trigger capabilities for routine operations.
    • Added inline documentation to clarify workflow execution conditions and behavior.

@bedatty bedatty self-assigned this Apr 24, 2026
@bedatty bedatty requested a review from a team as a code owner April 24, 2026 20:25
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 400e7509-3cf6-4cd1-8864-5d4548922118

📥 Commits

Reviewing files that changed from the base of the PR and between 1549b2e and ddcf096.

📒 Files selected for processing (1)
  • .github/workflows/self-routine.yml

Walkthrough

Modified GitHub Actions workflow to remove pull_request-triggered execution from four jobs (branch_cleanup_stale, stale_pr, stale_issue, labels_sync), retaining only schedule-based and workflow_dispatch triggers. Added inline documentation to labels_sync clarifying its push-to-main and labels file change dependency.

Changes

Cohort / File(s) Summary
Workflow Configuration
.github/workflows/self-routine.yml
Removed pull_request condition from branch_cleanup_stale, stale_pr, stale_issue, and labels_sync jobs; retained schedule and workflow_dispatch triggers. Added documentation comments above labels_sync job describing push-to-main and .github/labels.yml change requirements.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested labels

workflow, size/XS

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Title check ⚠️ Warning PR title 'fix(release): merge develop into main' does not match the actual changeset, which modifies workflow trigger conditions in .github/workflows/self-routine.yml, not a release merge. Align title with actual changes: 'fix(self-routine): tighten triggers per routine' or similar to reflect the trigger condition modifications made.
Description check ⚠️ Warning PR description lacks the required 'Description' section detailing which workflows are affected and what behavior changes. The template section is checked but the core summary is missing. Add a 'Description' section explaining that self-routine.yml jobs (branch_cleanup_stale, stale_pr, stale_issue, labels_sync) now trigger only on schedule/workflow_dispatch, removing pull_request-based execution.
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch develop

Comment @coderabbitai help to get the list of available commands and usage tips.

@lerian-studio lerian-studio added size/XS PR changes < 50 lines workflow Changes to one or more reusable workflow files labels Apr 24, 2026
@lerian-studio
Copy link
Copy Markdown
Contributor

🔍 Lint Analysis

Check Files Scanned Status
YAML Lint 1 file(s) ✅ success
Action Lint 1 file(s) ✅ success
Pinned Actions 1 file(s) ✅ success
Markdown Link Check no changes ⏭️ skipped
Spelling Check 1 file(s) ✅ success
Shell Check 1 file(s) ✅ success
README Check 1 file(s) ✅ success
Composite Schema no changes ⏭️ skipped
Deployment Matrix no changes ⏭️ skipped

🔍 View full scan logs

@lerian-studio
Copy link
Copy Markdown
Contributor

🛡️ CodeQL Analysis Results

Languages analyzed: actions

✅ No security issues found.


🔍 View full scan logs | 🛡️ Security tab

@bedatty bedatty merged commit a5204b7 into main Apr 24, 2026
23 checks passed
@coderabbitai coderabbitai Bot mentioned this pull request Apr 27, 2026
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS PR changes < 50 lines workflow Changes to one or more reusable workflow files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants