Conversation
Bumps the go-tooling group with 1 update: [goreleaser/goreleaser-action](https://github.com/goreleaser/goreleaser-action). Updates `goreleaser/goreleaser-action` from 7.1.0 to 7.2.1 - [Release notes](https://github.com/goreleaser/goreleaser-action/releases) - [Commits](goreleaser/goreleaser-action@e24998b...1a80836) --- updated-dependencies: - dependency-name: goreleaser/goreleaser-action dependency-version: 7.2.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: go-tooling ... Signed-off-by: dependabot[bot] <support@github.com>
fix(stale): collapse actions/stale verbose log + add custom summary
fix(self-routine): collapse to a single weekly cron firing all jobs
#285) Bumps the go-tooling group with 1 update: [goreleaser/goreleaser-action](https://github.com/goreleaser/goreleaser-action). Updates `goreleaser/goreleaser-action` from 7.1.0 to 7.2.1 - [Release notes](https://github.com/goreleaser/goreleaser-action/releases) - [Commits](goreleaser/goreleaser-action@e24998b...1a80836) --- updated-dependencies: - dependency-name: goreleaser/goreleaser-action dependency-version: 7.2.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: go-tooling ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: L. Bedatty <79675696+bedatty@users.noreply.github.com>
Resolves Pinned Actions lint failures by replacing version-tag and floating refs with full commit SHAs (with version comments) for: actions/checkout, actions/setup-go, actions/dependency-review-action, github/codeql-action/upload-sarif, securego/gosec.
Dependabot fails to apply the github-actions label referenced in .github/dependabot.yml because it does not exist in the repo. Defining it here lets labels-sync.yml create it on next run.
Pins the remaining external actions flagged by the Pinned Actions lint check: actions/upload-artifact, anchore/sbom-action, trufflesecurity/trufflehog, aquasecurity/trivy-action, and sonatype-nexus-community/nancy-github-action. Also moves trivy-action off the floating 0.35.0 tag to v0.36.0.
The SHA bbbca2dd... did not correspond to the v7 tag; replaces with 043fb46d... which matches v7.0.1 (verified via the actions/upload-artifact git ref API).
fix(go-security): pin external actions and add github-actions label
Bumps the security-scanners group with 1 update in the / directory: [sonatype-nexus-community/nancy-github-action](https://github.com/sonatype-nexus-community/nancy-github-action). Updates `sonatype-nexus-community/nancy-github-action` from 1.0.2 to 1.0.3 - [Release notes](https://github.com/sonatype-nexus-community/nancy-github-action/releases) - [Commits](sonatype-nexus-community/nancy-github-action@aae1964...726e338) --- updated-dependencies: - dependency-name: sonatype-nexus-community/nancy-github-action dependency-version: 1.0.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: security-scanners ... Signed-off-by: dependabot[bot] <support@github.com>
…evelop/security-scanners-999d30610d chore(deps): bump sonatype-nexus-community/nancy-github-action from 1.0.2 to 1.0.3 in the security-scanners group across 1 directory
WalkthroughThis PR introduces a new GitHub label for categorizing Actions ecosystem updates, pins multiple GitHub Actions to commit SHAs across security and release workflows, consolidates routine job scheduling from multiple cron expressions to a single weekly trigger, adjusts workflow trigger filters, and enhances logging and output handling in a stale action composite. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
🛡️ CodeQL Analysis ResultsLanguages analyzed: Found 1 issue(s): 1 Medium
🔍 View full scan logs | 🛡️ Security tab |
🔍 Lint Analysis
|
There was a problem hiding this comment.
Warning
CodeRabbit couldn't request changes on this pull request because it doesn't have sufficient GitHub permissions.
Please grant CodeRabbit Pull requests: Read and write permission and re-run the review.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
.github/workflows/go-release.yml (1)
99-111:⚠️ Potential issue | 🔴 CriticalDo not execute
inputs.test_cmddirectly.
inputs.test_cmdis caller-controlled shell in a reusable workflow, so external callers can run arbitrary commands with this job's permissions. Keep the test command fixed, or move it behind a trusted composite action with structured inputs.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/go-release.yml around lines 99 - 111, The "Run tests" step currently executes a caller-controlled shell via inputs.test_cmd which is a security risk; change the step so it does not run inputs.test_cmd directly—either replace run: ${{ inputs.test_cmd }} with a fixed test command (e.g., a vetted `go test ./...` invocation) or invoke a trusted composite action that accepts structured inputs and validates/limits allowed commands; update the step named "Run tests" and any usages of inputs.test_cmd in this workflow to use the fixed command or the composite action instead of executing arbitrary caller-provided shell..github/workflows/go-security.yml (1)
152-180:⚠️ Potential issue | 🟠 MajorNancy scanner findings are masked by two issues.
nancyhascontinue-on-error: trueat line 156, preventing step failure. More critically, thenancyjob result is not checked in thesecurity-summaryjob (lines 282–291), so even ifcontinue-on-erroris removed, nancy failures won't block the workflow whenfail_on_security_issuesis true.Trivy is correctly configured and will exit non-zero on findings (no
continue-on-error).Fix both:
- Remove
continue-on-error: truefrom nancy step- Add
${{ needs.nancy.result }}to the failure gate insecurity-summary(lines 283–287)🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/go-security.yml around lines 152 - 180, Remove the masking of Nancy findings by deleting the continue-on-error: true from the "Nancy vulnerability scan" step so the step fails on vulnerabilities, and update the conditional used in the "security-summary" job's failure gate to include the Nancy job result (add ${ { needs.nancy.result } } into the existing failure check) so security-summary considers Nancy failures when fail_on_security_issues is true.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/go-security.yml:
- Around line 101-108: Remove the '-no-fail' flag from the "Run Gosec Security
Scanner" step so gosec exits with a non‑zero code when vulnerabilities are
found; locate the step named "Run Gosec Security Scanner" (uses:
securego/gosec...) and update its with.args (remove '-no-fail' from '-no-fail
-fmt sarif -out gosec-results.sarif ./...') so the workflow can fail and the
security-summary gating (fail_on_security_issues) will detect gosec findings;
ensure the SARIF output and the "Upload Gosec SARIF" step remain unchanged.
---
Outside diff comments:
In @.github/workflows/go-release.yml:
- Around line 99-111: The "Run tests" step currently executes a
caller-controlled shell via inputs.test_cmd which is a security risk; change the
step so it does not run inputs.test_cmd directly—either replace run: ${{
inputs.test_cmd }} with a fixed test command (e.g., a vetted `go test ./...`
invocation) or invoke a trusted composite action that accepts structured inputs
and validates/limits allowed commands; update the step named "Run tests" and any
usages of inputs.test_cmd in this workflow to use the fixed command or the
composite action instead of executing arbitrary caller-provided shell.
In @.github/workflows/go-security.yml:
- Around line 152-180: Remove the masking of Nancy findings by deleting the
continue-on-error: true from the "Nancy vulnerability scan" step so the step
fails on vulnerabilities, and update the conditional used in the
"security-summary" job's failure gate to include the Nancy job result (add ${ {
needs.nancy.result } } into the existing failure check) so security-summary
considers Nancy failures when fail_on_security_issues is true.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yml
Review profile: ASSERTIVE
Plan: Pro
Run ID: c6dfe0c9-0819-4d30-b80f-a1cb23d49ee1
📒 Files selected for processing (6)
.github/labels.yml.github/workflows/go-release.yml.github/workflows/go-security.yml.github/workflows/self-release.yml.github/workflows/self-routine.ymlsrc/config/stale/action.yml
GitHub Actions Shared Workflows
Description
Type of Change
feat: New workflow or new input/output/step in an existing workflowfix: Bug fix in a workflow (incorrect behavior, broken step, wrong condition)perf: Performance improvement (e.g. caching, parallelism, reduced steps)refactor: Internal restructuring with no behavior changedocs: Documentation only (README, docs/, inline comments)ci: Changes to self-CI (workflows under.github/workflows/that run on this repo)chore: Dependency bumps, config updates, maintenancetest: Adding or updating testsBREAKING CHANGE: Callers must update their configuration after this PRBreaking Changes
None.
Testing
@developor the beta tagCaller repo / workflow run:
Related Issues
Closes #
Summary by CodeRabbit
Release Notes