docs(helm-upgrade-doc): update Slack channel secret to generic SLACK_CHANNEL - #644
Conversation
…CHANNEL Follow-up to #643 (which merged the generic SLACK_CHANNEL in the workflow but left the doc stale). docs/helm-upgrade-doc.md still listed SLACK_CHANNEL_DEVOPS; update it to SLACK_CHANNEL with a note on mapping a channel secret in the caller. Closes the CodeRabbit doc-consistency finding. X-Lerian-Ref: 0x1
🔍 PR Validation Summary✅ PR Mergeable — no blocking failures
|
🔍 Lint Analysis
|
Summary by CodeRabbit
WalkthroughThe Helm upgrade documentation replaces ChangesHelm upgrade documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Warning
CodeRabbit couldn't request changes on this pull request because it doesn't have sufficient GitHub permissions.
Please grant CodeRabbit Pull requests: Read and write permission and re-run the review.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/helm-upgrade-doc.md`:
- Line 109: Update the SLACK_CHANNEL documentation to state that callers using
differently named secrets, such as SLACK_CHANNEL_OPS, must replace secrets:
inherit with an explicit secrets: mapping covering every required secret,
including SLACK_CHANNEL, so Slack notifications receive the channel value.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 7d952b16-3272-4736-ae9d-388bd15211a3
📒 Files selected for processing (1)
docs/helm-upgrade-doc.md
…nherit Address CodeRabbit: note that secrets: inherit matches by name and does not rename SLACK_CHANNEL_OPS to SLACK_CHANNEL — callers need a secret named SLACK_CHANNEL, or an explicit secrets mapping (inherit cannot be combined with an explicit secrets block). X-Lerian-Ref: 0x1
There was a problem hiding this comment.
Warning
CodeRabbit couldn't request changes on this pull request because it doesn't have sufficient GitHub permissions.
Please grant CodeRabbit Pull requests: Read and write permission and re-run the review.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/helm-upgrade-doc.md`:
- Line 119: Remove the standalone empty blockquote marker on line 119 in the
documentation so the blockquote has no blank quoted line and satisfies
markdownlint MD028.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 08b08aee-3bba-4c4b-a3f4-a82af2c845f5
📒 Files selected for processing (1)
docs/helm-upgrade-doc.md
Description
Follow-up to #643. That PR merged the generic
SLACK_CHANNELsecret into thehelm-upgrade-docworkflow but leftdocs/helm-upgrade-doc.mdreferencing the oldSLACK_CHANNEL_DEVOPS. This updates the doc toSLACK_CHANNEL, with a note that callers map any channel secret to it (e.g.SLACK_CHANNEL: ${{ secrets.SLACK_CHANNEL_OPS }}).Resolves the CodeRabbit doc-consistency finding raised on #642/#643.
Type of Change
docs: Documentation onlyMigration
None — doc-only.