Fix Membase Refit client deserializing graph values as inferred types - #10
Merged
iceljc merged 1 commit intoAug 3, 2026
Conversation
Refit 8's default serializer adds ObjectToInferredTypesConverter, so Dictionary<string, object?> response values arrive as string/double/Dictionary instead of JsonElement, silently emptying every consumer that does TryGetValue<JsonElement> (GraphBuilder, query_flow_graph, similarity search result parsing). Register the client with plain Web JsonSerializerOptions. Also fail with a clear message in ProviderHelper when no LlmProviders entry exists for the requested model instead of a NullReferenceException. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refit 8's default serializer adds ObjectToInferredTypesConverter, so Dictionary<string, object?> response values arrive as string/double/Dictionary instead of JsonElement, silently emptying every consumer that does TryGetValue (GraphBuilder, query_flow_graph, similarity search result parsing). Register the client with plain Web JsonSerializerOptions.
Also fail with a clear message in ProviderHelper when no LlmProviders entry exists for the requested model instead of a NullReferenceException.