Skip to content

Disable webhookReply by default#9

Merged
LetItCode merged 1 commit into
LetItCode:dev3-39from
oswebex:fix-webhook-reply
Feb 11, 2021
Merged

Disable webhookReply by default#9
LetItCode merged 1 commit into
LetItCode:dev3-39from
oswebex:fix-webhook-reply

Conversation

@oswebex

@oswebex oswebex commented Feb 11, 2021

Copy link
Copy Markdown

Description

webhookReply is an endless source of issues. To increase reliability (and reduce the number of "bug" reports), I suggest disabling it by default. Instead, I'd encourage people to enable it on per-call basis and document the gotchas:

  1. Errors in the webhookReply calls cannot be reported.
  2. webhookReply calls break ordering by resolving before bot API has a chance to process them (Async/Await in Webhook updates telegraf/telegraf#1167, messages with attachments in wrong order telegraf/telegraf#1086).
  3. webhookReply call confirms the update, which means it won't be processed again if bot crashes.

Type of change

  • Feature fix

@LetItCode
LetItCode merged commit 52688e0 into LetItCode:dev3-39 Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants