Making code backwards compatible#333
Closed
codecracker2014 wants to merge 1 commit into
Closed
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
Contributor
|
This feels like a step backwards. I will reject this, for now. I would prefer if the current OpenPDF Java API would remain stable for a while now, unless there are very strong reasons for changing the API. xdocreport should just simply be updated to use Generics from Java 8 and later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request changes will make xdoc-reports compatible with OpenPDF. Also these changes should be done to maintain backward compatibility.
Related commit - #210