Skip to content

libvisual-plugins: Fix out-of-bounds access for actor "infinite"#202

Merged
hartwork merged 5 commits intomasterfrom
infinite-fix-out-of-bounds-access
Jan 23, 2023
Merged

libvisual-plugins: Fix out-of-bounds access for actor "infinite"#202
hartwork merged 5 commits intomasterfrom
infinite-fix-out-of-bounds-access

Conversation

@hartwork
Copy link
Copy Markdown
Member

@hartwork hartwork commented Jan 23, 2023

Foward-port of 0.4.x pull request #200

@hartwork
Plugins (infinite): Resolve _inf_load_effects and building ints from …
9f1f4a5 
…bytes

Now this has a chance of working on big-endian machines.

(cherry picked from commit c2bba3f)
@hartwork
Plugins (infinite): Clarify x/y coordinate unpacking
346bba1 
Related packing code:
> compute.c: vector_field[b_add+add].coord=(x<<16)|y;

(cherry picked from commit 5179a45)
@hartwork
Plugins (infinite): Fix out-of-bounds reads in _inf_compute_surface
063b609 
(cherry picked from commit abccc80)
@hartwork hartwork added this to the 0.5.0_alpha1 milestone Jan 23, 2023
@hartwork hartwork requested a review from kaixiong January 23, 2023 16:17
@hartwork
Plugins (infinite): Streamline method _inf_compute_surface
5b1ea02 
- Save write to add_src
- Save adding 0 for absent neighbors
- Use "foo[index]" rather than "*(foo + index)" for reability
- Simplify interpol->weight byte unpacking

Ideas by Chong Kai Xiong (@kaixiong)

(cherry picked from commit b7fc821)
@hartwork hartwork force-pushed the infinite-fix-out-of-bounds-access branch from 0a8ca9c to 5b1ea02 Compare January 23, 2023 16:20
kaixiong
kaixiong requested changes Jan 23, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@kaixiong kaixiong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor change to make.

Comment thread libvisual-plugins/plugins/actor/infinite/display.c Outdated
@hartwork hartwork requested a review from kaixiong January 23, 2023 17:25
@hartwork hartwork merged commit c41616b into master Jan 23, 2023
@hartwork hartwork mentioned this pull request Jan 23, 2023
Merged
@hartwork hartwork deleted the infinite-fix-out-of-bounds-access branch January 23, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaixiong kaixiong kaixiong approved these changes

Assignees

No one assigned

Labels

bug porting: done

Projects

None yet

Milestone

0.5.0_alpha1

Development

Successfully merging this pull request may close these issues.

2 participants

@hartwork @kaixiong