Add features to filmorate#25
Merged
LightInTheFire merged 13 commits intomainfrom Oct 22, 2025
Merged
Conversation
* feat: added contributors, tables description and updated db_schema.svg in README * fix: added line breaks in readme
* feat: added director model, it's dto's, mapper and added tables in schema * feat: added director controller impl and service interface * feat: added request body message not readable handler * fix:changed errorName to name to satisfy tests * feat: added dao layer for director * feat: added director service * feat: updated film model and dto's to contain directors * feat: refactored film to use group_concat inside select, transferred all methods to use rowmapper instead of RSEz * feat: added endpoint to find films of director sorted by year or likes count
* feat: added search by genres and years * fix: changed type params genreId and year to wrappers
* up to date to changes * fix conflicts * rebase changes * update methods for new code --------- Co-authored-by: Egor Ilyin <basementdoor@yandex.com>
* feat: added reviews * fix: checkstyle * fix: refactored ReviewServiceImpl, added responseStatus
* fix: added subdirectories to service package fixed tests * fix: distinct genres and directors
* Add files via upload * Add files via upload * Add files via upload * Delete src/main/java/ru/yandex/practicum/filmorate/repository/feed * Add files via upload * Add files via upload * Update UserServiceImpl.java * Update ReviewServiceImpl.java * Update FilmServiceImpl.java * Update schema.sql * Update Event.java * Add files via upload * Add files via upload * Add files via upload * Update FeedService.java * Update FeedServiceImpl.java * Update FeedController.java * Update UserServiceImpl.java * Update FilmServiceImpl.java * Update ReviewServiceImpl.java * Update JdbcFeedRepository.java * Delete src/main/java/ru/yandex/practicum/filmorate/mapper/EventRowMapper.java * Add files via upload * Update FeedController.java * Update FeedController.java * Update JdbcFeedRepository.java * Update FeedService.java * Update FeedServiceImpl.java * Update FilmServiceImpl.java * Update UserServiceImpl.java * Update ReviewServiceImpl.java * Update EventDto.java * Update EventMapper.java * Update EventMapper.java
* fix: order reviews by useful rating * fix: change group concat to subquery for correct genres mapping * fix: changed insert to do nothing when data is present
Ivanov-s-tmn
left a comment
Ivanov-s-tmn
left a comment
There was a problem hiding this comment.
Всем, привет! Оставил обратную связь по групповому проекту, вы отлично поработали и в целом все хорошо, есть только небольшие точечные моменты, которые нужно поправить.
Так же, не забывайте, что когда работаете над одним проектом, стоит придерживаться общего стиля кода, чтобы он смотрелся и читался как единое целое, а не что-то слепленное из разных частей)
Если будут вопросы по моим комментариям, готов помочь.
Хорошего вечера!
* fix film recommendations after review * fix: count distinct likes --------- Co-authored-by: Egor Ilyin <basementdoor@yandex.com> Co-authored-by: Ilia Egorov <aleilmessia@mail.ru>
* feat: add dockerfile and docker compose * fix: removed @validated unnecessary annotations * fix: update Dockerfile * fix: changed timestamp name in bd to created_at * chore: changed return dto's to records * fix: changed null to optional * fix: corrected likes count * fix: changed timestamp to created_at
* fix: refractor likes methods * fix: edited sql in updateUsefulRating method
Ivanov-s-tmn
left a comment
Ivanov-s-tmn
left a comment
There was a problem hiding this comment.
Всем привет! Все отлично, у меня больше нет замечаний.
Удачи дальше, хорошего дня и продуктивной недели!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Добавлены фичи согласно ТЗ