fix(streaming): unblock macOS 3.14 DataLoader restore CI hangs#855
Merged
Conversation
Skip the two non-persistent multi-epoch restore tests on darwin+3.14 where CI hangs in the worker queue, fail fast when local chunks are missing, and daemonize/cancel asyncio executor threads on prepare-thread teardown. Co-authored-by: Cursor <cursoragent@cursor.com>
Use getattr for prefetch/force-download handles so ParquetLoader and bare test loaders do not AttributeError, and always invoke force_download after the grace period so local fail-fast does not skip that path. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #855 +/- ##
===================================
Coverage 81% 81%
===================================
Files 56 56
Lines 8389 8397 +8
===================================
+ Hits 6794 6801 +7
- Misses 1595 1596 +1 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_dataloader_states_with_persistent_workersand other platforms)._wait_until_chunk_readyfor local uncompressed caches (no prefetch thread) instead of polling for_MAX_WAIT_TIME(often equal to the pytest timeout).Follow-up to #852 after macOS-14 / 3.14 CI failures in
test_dataloader_with_loading_statesandtest_resume_dataloader_with_new_dataset.Test plan
pytester (macos-14, 3.14)greenMade with Cursor