-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Update CODEOWNERS #5561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CODEOWNERS #5561
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5561 +/- ##
=======================================
+ Coverage 90% 93% +3%
=======================================
Files 134 134
Lines 10055 10055
=======================================
+ Hits 9040 9388 +348
+ Misses 1015 667 -348 |
|
Hey @carmocca, Would you mind adding Justus to Best regards, |
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
tchaton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
|
@carmocca i think this looks good accept for the API files- we still need will to approve them. Is it possible to have both tchaton and williamFalcon approve the API files? |
The only reason for adding @tchaton to these API files is to avoid blocking small changes to these files (docs updates, formatting changes, minor bug fixes, non-api refactors, typing improvements...) This requires putting trust on him (great power, great responsability 🕷️). As he would have the power to circumvent @williamFalcon's approval If you/he are not okay with this. It is better to keep only @williamFalcon as the only CODEOWNER of these files because we wouldn't be gaining anything by requiring both. |
|
yeas the main reason is just not to be blocked with simple typos... @edenlightning do you have any other suggestion? 🐰 |
* Update CODEOWNERS * Update CODEOWNERS * Apply suggestions from code review Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com> * Apply suggestions from code review Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: edenlightning <66261195+edenlightning@users.noreply.github.com>
* Update CODEOWNERS * Update CODEOWNERS * Apply suggestions from code review Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com> * Apply suggestions from code review Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: edenlightning <66261195+edenlightning@users.noreply.github.com>
* Update CODEOWNERS * Update CODEOWNERS * Apply suggestions from code review Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com> * Apply suggestions from code review Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: edenlightning <66261195+edenlightning@users.noreply.github.com>
What does this PR do?
cc @Borda