Skip to content

fix pip install #7170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2021
Merged

fix pip install #7170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pytorch_lightning/setup_tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ def _load_requirements(path_dir: str, file_name: str = 'requirements.txt', comme
if comment_char in ln:
ln = ln[:ln.index(comment_char)].strip()
# skip directly installed dependencies
if ln.startswith('http'):
if ln.startswith('http') or '@http' in ln:
continue
if ln: # if requirement is not empty
reqs.append(ln)
Expand Down
2 changes: 1 addition & 1 deletion requirements/extra.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@ torchtext>=0.5
onnxruntime>=1.3.0
hydra-core>=1.0
# todo: when switch to standard package stream, drop `fairscale` from hard mocked docs libs
fairscale @ https://github.com/PyTorchLightning/fairscale/archive/pl_1.2.0.zip
fairscale @https://github.com/PyTorchLightning/fairscale/archive/pl_1.2.0.zip
jsonargparse[signatures]>=3.9.0