Skip to content
This repository was archived by the owner on Aug 28, 2025. It is now read-only.

Conversation

@krshrimali
Copy link
Contributor

@krshrimali krshrimali commented Nov 4, 2022

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fix scripts: remove /usr/bin/python

Fixing the publishing workflow. Sorry, this was overlooked in #183 by me. Wasn't aware that it will go as a cell. Let's see what does the CI do now.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Merging #208 (ca9ec7d) into main (5d1268b) will not change coverage.
The diff coverage is 100%.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #208   +/-   ##
===================================
  Coverage    75%    75%           
===================================
  Files         2      2           
  Lines       370    370           
===================================
  Hits        276    276           
  Misses       94     94           

@Borda Borda changed the title Fix CI: remove /usr/bin/python Fix scripts: remove /usr/bin/python Nov 4, 2022
@Borda Borda enabled auto-merge (squash) November 4, 2022 18:48
@krshrimali krshrimali disabled auto-merge November 4, 2022 19:06
@Borda Borda enabled auto-merge (squash) November 4, 2022 19:50
@Borda
Copy link
Contributor

Borda commented Nov 4, 2022

the 5306cea is preventing Lightning-AI/pytorch-lightning#15455
will be fixed in 1.8.1

@Borda Borda changed the title Fix scripts: remove /usr/bin/python Fix scripts and docs Nov 4, 2022
@Borda Borda merged commit 46eb6a2 into main Nov 4, 2022
@Borda Borda deleted the tutorials-fix branch November 4, 2022 22:48
@Borda Borda mentioned this pull request Nov 4, 2022
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants