Fix utils header ODR issues - #81
Merged
Merged
Conversation
Mark free functions in argument_utils and path_utils as inline to avoid multiple definitions across translation units.\n\nConfirmed no other non-inline free functions with external linkage remain in the public headers beyond templates.
Add a one-second deadline when draining before an MPSC hot resize so producers are released even if the worker is stalled. Document the abort behaviour and that non-MPSC builds are unaffected.
Bound MPSC hot-resize wait to avoid stalls
Fix benchmark start barrier deadlock
Fix spdlog async bench crash and MPSC dequeue reliability
Ensure LatencyRecorder completion is synchronized across async spdlog sinks and hold recorder lifetime in adapters. Add ASAN CI job for spdlog async/null scenario.
Guard spdlog async bench recorder lifetime and add ASAN check
Prevent MeasuringSink from deleting payloads while the async thread pool may still dereference them by moving completed entries into a retired list.
Retain spdlog bench payloads until async queue drains
Ensure pending async messages drain before completing tokens to avoid recorder overcounts and incomplete latency capture.
Wait for spdlog sink to drain before completing tokens
Ensure file_logger_test writes into its own directory so parallel Linux runs don't cross-contaminate files.
Isolate file_logger_test log directory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_690b0e3570e08328aed9c759910266f9