IOS-163: RC update #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* correctly detect colors with alpha component * fix color for paywalls v1
* New overrides in API layer * Overrides do their thing * Added tests
…Cat#4717) * Move SwiftUI preview behind DEBUG flag * Retrun ci
* Move SwiftUI preview behind DEBUG flag * Retrun ci * Fix paywalls badge rendering
…r` (RevenueCat#4721) * Deprecate paywallFooter for paywallFooterForV1 * Updated some comments * Fix lint * Rename to originalTemplatePaywallFooter
* Add Timeline component * rename text -> title * struct -> class * lint
* A few badge-related changes: - Position the Overlaid badge in the middle if the border instead of its outer edge. - Position Nested badges inside the border of the stack by default. - Clip trailing/leading edge-to-edge badges, as well as nested badges, to prevent them form rendering outside the bounds of the stack. - This requited us to extract the Shadow from the Shape modifier so they can be applied separatedly. This allows us to apply the badge modifier in the middle, and let it clip the stack before applying the Shadow. * move shape helpers back to Shape.swift * Fix support for badge padding * add back shadow to shape previews * Fix edge-to-edge top/bottom badges * fix shadow * add previews for different stack shapes properly support top/bottom edge-to-edge badges by extending them behind the stack * no longer needed to make badge full width * use rectangle as default shadow shape * Ensure the border appears over the nested badge in case it needs to clip * lint
* add new opt-in public API `uiPreviewMode` to `DangerousSettings` * fix: add missing `convenience` to `uiPreviewInitializer` of `DangerousSettings` * docs: change documentation of `DangerousSettings` init * test: add API test for new `DangerousSettings` init
* Fix footer spacing issues * Fix lint
…ix OS/platform compile issues (RevenueCat#4727) * We can't just remove PAYWALL_COMPONENT because we don't support macos and tv and things were failing * Move PartialComponent outside of PaywallComponent extension * Fix some lint errors * Wrong thing * Undid things i shouldn't have done * Removed more * Added comment * Removed/fix some places for the check thingies * RevenueCat module compiles on all the things * RevenueCatUI compiles in all the platforms now * Make all the things compile again * Make work for visionOS * Fix some platform and xcode version issues * Fix failing spm ios 15 test * Undo circleci changes * Replace smooth with easeInOut * Only run the thing i want * Attempt to remove circular * Explicit returns * Does this pass * This is it * Swift 5.9 for this * All tests again * Undid public testing processor stuff * Undo this too * Swift compiler check out pill style circular * Fixes from PR review * Fix compile for mac
* Support variable mapping * Added support for variable mapping * Better
* Add background property to Stack component which will supersede the backgroundColor property * fix
* Ignore top safe area edges for image * Fixed lint and supported more things * These feels better I think * Fix lint * Fix from PR review
* feat: use fix, hardcoded `appUserID` for UI preview mode * test: add unit tests for user ID in UI preview mode * fix linter's Trailing Whitespace Violations * PR RevenueCat#4725 comments * Change default appUserID for UI Preview mode. * Add debug log regarding the use of UI Preview mode user ID.
* Adds full cover option to paywalls tester * Fixes from PR
…eck` implementation (RevenueCat#5022) * Forks into a separate method to be preserver backwards compatibility * Resets `PurchasesDiagnosticsHealth` to state before merge * Adds missing unit tests * Fixes lint errors * Fixes errors * Updates documentation * Moves types under the debug flag * Moves more types under debug * Adds reference to error in documentations
* Fixes blank lines not showing up * Changes to inlineOnly * fix: Wrap viewmodel binding into another binding (RevenueCat#5023) * Fixes blank lines not showing up * Changes to inlineOnly * Updates a comment. * comment typo --------- Co-authored-by: Facundo Menzella <facumenzella@users.noreply.github.com>
RevenueCat#5025) * Add abstraction to StoreKit's `manageSubscriptionsSheet` in `CustomerCenterPurchasesType` * add public init to `ManageSubscriptionSheetModifier` * Make `CustomerCenterPurchasesType`'s `manageSubscriptionsSheetViewModifier` method `@MainActor` * fix lint
kaiengelhardt
approved these changes
May 5, 2025
kaiengelhardt
left a comment
kaiengelhardt
left a comment
There was a problem hiding this comment.
Looks good to me! I left you two comments, but nothing groundbreaking.
liborpolehna
approved these changes
May 6, 2025
g-laures
force-pushed
the
glaures/IOS-163-RC-update
branch
from
05efdea to
445d1f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated RC from 5.3.0 to 5.22.2.
Not a lot of conflicts after the cleanup.
You can have a look at the commits after the merge.