Skip to content

chore: scaffold pronote monorepo - #2

Merged
Linoux-re merged 1 commit into
mainfrom
codex/build-comprehensive-web-application
Sep 30, 2025
Merged

chore: scaffold pronote monorepo#2
Linoux-re merged 1 commit into
mainfrom
codex/build-comprehensive-web-application

Conversation

@Linoux-re

Copy link
Copy Markdown
Owner

Summary

  • bootstrap pnpm workspace with Next.js web app and NestJS API
  • add shared config, UI, and utility packages with sample tests
  • document environment setup with docker compose, env template, and prisma schema

Testing

  • not run

https://chatgpt.com/codex/tasks/task_e_68dc28a98ffc83298dc7428b4c2d8710

@Linoux-re
Linoux-re merged commit ebc1185 into main Sep 30, 2025
1 check failed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

Comment thread apps/api/package.json
Comment on lines +1 to +9
{
"name": "api",
"private": true,
"type": "module",
"scripts": {
"dev": "nest start --watch",
"build": "nest build",
"start": "node dist/main.js",
"start:prod": "node dist/main.js",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Align Nest build output with package module type

The API package is declared as ESM ("type": "module"), but the TypeScript config still emits CommonJS and the runtime scripts execute node dist/main.js. With this setup Node will load the compiled files as ES modules and immediately throw because the generated code uses require/module.exports. As a result pnpm dev/pnpm start:prod cannot boot the Nest server after a fresh build. Either drop the type: module flag or change the compiler output to ESM so the runtime format matches.

Useful? React with 👍 / 👎.

Comment thread docker/Dockerfile.api
Comment on lines +1 to +7
FROM node:20-alpine
WORKDIR /app
COPY package.json pnpm-workspace.yaml .npmrc* .pnpmfile.cjs* ./
COPY apps ./apps
COPY packages ./packages
COPY prisma ./prisma
RUN corepack enable && pnpm install --frozen-lockfile

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Docker images cannot build without pnpm lockfile

Both API and web Dockerfiles execute pnpm install --frozen-lockfile, but the repository does not include a pnpm-lock.yaml. When the frozen flag is used and no lockfile is present, pnpm aborts with Lockfile is missing, so docker build for either service fails immediately. Either commit a lockfile or drop the --frozen-lockfile option in these images.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant